Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate .bat files on Windows platform #2094

Merged
merged 4 commits into from Nov 22, 2017

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Nov 22, 2017

Fixes #2083

@segiddins
Copy link
Member

@bundlerbot r+

@bundlerbot
Copy link
Collaborator

📌 Commit 226ddc1 has been approved by segiddins

@bundlerbot
Copy link
Collaborator

⌛ Testing commit 226ddc1 with merge a20ea7d...

bundlerbot added a commit that referenced this pull request Nov 22, 2017
Generate .bat files on Windows platform

Fixes #2083
@bundlerbot
Copy link
Collaborator

☀️ Test successful - status-travis
Approved by: segiddins
Pushing a20ea7d to master...

@bundlerbot bundlerbot merged commit 226ddc1 into rubygems:master Nov 22, 2017
@hsbt hsbt deleted the generate-win-bundler-bat branch November 22, 2017 13:33
@hsbt
Copy link
Member Author

hsbt commented Nov 22, 2017

I confirmed this fix generates "bundle.bat" on bin directory like C:\path\to\Ruby24-x64\bin on my windows env. (but this test was broken. I will fix it.)

bundlerbot added a commit that referenced this pull request Nov 23, 2017
Revise my fixes for Rubygems 2.7.2

* Applied to fix #2086 (comment) .
* Fix a name of gemspec directories on tests
* Fix a test for #2094 . It asserts wrong bin path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants