Use setup command --regenerate-binstubs option flag #2099
Conversation
Tasks:
Let me know if I should adapt those patches. To be honest the test Depends on #2098This build will fail will following error: Because if we run |
ghost
changed the title
ghost
mentioned this pull request
Since 909b5fb, executable wrappers are regenerated using pristine command if any gem are installed. New test is inspired by those for Gem::Commands::PristineCommand.
`--[no-]regenerate-binstubs' option flag was added in 909b5fb but is not used yet. This change tests if the option was set before calling Gem::Commands::SetupCommand#regenerate_binstubs. We also simplify how the option is set, since it's more similar to `format_executable' for example (simple option flag), rather than `document' where we use the same hash key for multiple options. This way we can just test the value being either true or false, instead of testing key presence (`Hash#key?') or relying on `nil' being returned for nonexistent hash keys with `Hash#[]'.
#2098 was merged, build is now OK. Please let me know if I should improve anything in this PR |
|
@segiddins, thank you for the review! I'm still working on changes for setup command, and I'm now wondering Because if I'm correct, it's about RubyGems executable wrappers, and I understand that Bundler features are merged into RubyGems, but both Am I wrong? If not, should I open an issue or suggest a PR? Thanks. |
|
That's a good point, and I'm not sure what the answer is? Let's keep it the way it is for now |
|
@bundlerbot r+ |
|
📌 Commit 4619f13 has been approved by |
Use setup command --regenerate-binstubs option flag Test setup command binstubs regeneration ---------------------------------------- Since 909b5fb, executable wrappers are regenerated using pristine command if any gem are installed. New test is inspired by those for `Gem::Commands::PristineCommand`. Fix setup command --regenerate-binstubs option flag --------------------------------------------------- `--[no-]regenerate-binstubs` option flag was added in 909b5fb but is not used yet. This change tests if the option was set before calling `Gem::Commands::SetupCommand#regenerate_binstubs`. We also simplify how the option is set, since it's more similar to `format_executable` for example (simple option flag), rather than `document` where we use the same hash key for multiple options. This way we can just test the value being either true or false, instead of testing key presence (`Hash#key?`) or relying on `nil` being returned for nonexistent hash keys with `Hash#[]`.
|
☀️ Test successful - status-travis |
Test setup command binstubs regeneration
Since 909b5fb, executable wrappers are regenerated using pristine
command if any gem are installed. New test is inspired by those for
Gem::Commands::PristineCommand.Fix setup command --regenerate-binstubs option flag
--[no-]regenerate-binstubsoption flag was added in 909b5fb but isnot used yet. This change tests if the option was set before calling
Gem::Commands::SetupCommand#regenerate_binstubs.We also simplify how the option is set, since it's more similar to
format_executablefor example (simple option flag), rather thandocumentwhere we use the same hash key for multiple options. Thisway we can just test the value being either true or false, instead of
testing key presence (
Hash#key?) or relying onnilbeing returnedfor nonexistent hash keys with
Hash#[].