Support option for --destdir with upgrade installer.
#2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original patch was created by @tjouan. #2134 (comment) Fixes #2134
|
@bundlerbot r+ |
|
📌 Commit 3097ad7 has been approved by |
|
⌛ Testing commit 3097ad7 with merge 196d79e... |
bundlerbot
added a commit
that referenced
this pull request
Feb 2, 2018
Support option for `--destdir` with upgrade installer. # Description: the original patch was created by @tjouan. #2134 (comment) Fixes #2134 ______________ I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
☀️ Test successful - status-travis |
hsbt
pushed a commit
that referenced
this pull request
Feb 2, 2018
Support option for `--destdir` with upgrade installer. # Description: the original patch was created by @tjouan. #2134 (comment) Fixes #2134 ______________ I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
4 tasks
bundlerbot
added a commit
that referenced
this pull request
Feb 5, 2018
Fix regression of destdir on Windows platform # Description: Followup #2134 and #2169 `Gem::Specification.default_specifications_dir` returns full path contained "C:/..." string on Windows platform. Windows couldn't handle C:/... suffix string like "C:/foo/C:/bar". I ignored destdir options with upgrade installer when it invoked on Windows. ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
hsbt
pushed a commit
that referenced
this pull request
Feb 5, 2018
Fix regression of destdir on Windows platform # Description: Followup #2134 and #2169 `Gem::Specification.default_specifications_dir` returns full path contained "C:/..." string on Windows platform. Windows couldn't handle C:/... suffix string like "C:/foo/C:/bar". I ignored destdir options with upgrade installer when it invoked on Windows. ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
the original patch was created by @tjouan.
#2134 (comment)
Fixes #2134
I will abide by the code of conduct.