Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RequestSet] Only suggest a gem version with an installable platform #2175

Merged
merged 1 commit into from Feb 13, 2018

Conversation

segiddins
Copy link
Member

Description:

Should fix #2156 by skipping over gem versions that wouldn't be installable locally

@bundlerbot
Copy link
Collaborator

☔ The latest upstream changes (presumably #2177) made this pull request unmergeable. Please resolve the merge conflicts.

@segiddins
Copy link
Member Author

@bundlerbot r+

@bundlerbot
Copy link
Collaborator

📌 Commit 3461ae4 has been approved by segiddins

@bundlerbot
Copy link
Collaborator

⌛ Testing commit 3461ae4 with merge e9a9b63...

bundlerbot added a commit that referenced this pull request Feb 12, 2018
…r=segiddins

[RequestSet] Only suggest a gem version with an installable platform

# Description:

Should fix #2156 by skipping over gem versions that wouldn't be installable locally
@bundlerbot
Copy link
Collaborator

💔 Test failed - status-travis

@hsbt
Copy link
Member

hsbt commented Feb 13, 2018

@bundlerbot retry

@bundlerbot
Copy link
Collaborator

⌛ Testing commit 3461ae4 with merge 9fccdc9...

bundlerbot added a commit that referenced this pull request Feb 13, 2018
…r=segiddins

[RequestSet] Only suggest a gem version with an installable platform

# Description:

Should fix #2156 by skipping over gem versions that wouldn't be installable locally
@bundlerbot
Copy link
Collaborator

☀️ Test successful - status-travis
Approved by: segiddins
Pushing 9fccdc9 to master...

@bundlerbot bundlerbot merged commit 3461ae4 into master Feb 13, 2018
@segiddins segiddins deleted the seg-request-set-installable-platform branch February 13, 2018 21:48
@hsbt hsbt added this to the 2.7.6 milestone Feb 13, 2018
hsbt pushed a commit that referenced this pull request Apr 28, 2018
…r=segiddins

[RequestSet] Only suggest a gem version with an installable platform

# Description:

Should fix #2156 by skipping over gem versions that wouldn't be installable locally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby version incompatibility message wrong for multiplatform gem
4 participants