Ignore perfomance test of version regexp pattern. #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes its test fail with old ruby versions like Ruby 1.9 and 1.8
|
@bundlerbot r+ |
|
📌 Commit 3e82dfb has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Feb 5, 2018
… r=hsbt Ignore perfomance test of version regexp pattern. # Description: Sometimes its test fail with old ruby versions like Ruby 1.8 * https://ci.appveyor.com/project/segiddins/rubygems/build/1094/job/knb2oiu7jwb4fjp5 * https://travis-ci.org/rubygems/rubygems/jobs/337402882 ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-travis |
hsbt
pushed a commit
that referenced
this pull request
Feb 5, 2018
… r=hsbt Ignore perfomance test of version regexp pattern. # Description: Sometimes its test fail with old ruby versions like Ruby 1.8 * https://ci.appveyor.com/project/segiddins/rubygems/build/1094/job/knb2oiu7jwb4fjp5 * https://travis-ci.org/rubygems/rubygems/jobs/337402882 ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Sometimes its test fail with old ruby versions like Ruby 1.8
Tasks:
I will abide by the code of conduct.