Cleanup deprecated style #2193
Merged
Cleanup deprecated style #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
force-pushed
the
cleanup-deprecated-style
branch
from
a266942
to
f61baa5
Compare
|
@bundlerbot r+ |
|
📌 Commit 3dc5728 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Feb 16, 2018
Cleanup deprecated style # Description: Followed up to remove old ruby versions. I did clean up redundant/deprecated sections on gemspec and travis.yml. ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
@bundlerbot r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 3dc5728 has been approved by |
|
@bundlerbot retry |
bundlerbot
added a commit
that referenced
this pull request
Feb 16, 2018
Cleanup deprecated style # Description: Followed up to remove old ruby versions. I did clean up redundant/deprecated sections on gemspec and travis.yml. ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
☀️ Test successful - status-travis |
segiddins
reviewed
Feb 16, 2018
| @@ -1,44 +1,36 @@ | |||
| # -*- encoding: utf-8 -*- | |||
| # stub: rubygems-update 2.7.4 ruby hide_lib_for_update | |||
|
|
|||
| Gem::Specification.new do |s| | |||
| s.name = "rubygems-update".freeze | |||
| s.version = "2.7.4" | |||
There was a problem hiding this comment.
should this be reading from lib/rubygems.rb?
segiddins
reviewed
Feb 16, 2018
| s.rdoc_options = ["--main".freeze, "README.md".freeze, "--title=RubyGems Update Documentation".freeze] | ||
| s.extra_rdoc_files = [ |
There was a problem hiding this comment.
should this include the bundler manpages?
segiddins
reviewed
Feb 16, 2018
| "bundler/CONTRIBUTING.md".freeze, "bundler/LICENSE.md".freeze, "bundler/README.md".freeze, | ||
| "hide_lib_for_update/note.txt".freeze, | ||
| ] | ||
|
|
||
| s.required_ruby_version = Gem::Requirement.new(">= 2.2.2".freeze) | ||
| s.rubygems_version = "2.7.3".freeze |
There was a problem hiding this comment.
I believe this should be removed, it's set by RubyGems when building
hsbt
added a commit
that referenced
this pull request
Mar 3, 2018
bundlerbot
added a commit
that referenced
this pull request
Mar 5, 2018
Improve gemspec and package task. # Description: Followed up #2193 (review) and Improve package task. ______________ # Tasks: - [x] Describe the problem / feature - [x] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
hsbt
pushed a commit
to rubygems/rubygems-server
that referenced
this pull request
Sep 24, 2021
Improve gemspec and package task. # Description: Followed up rubygems/rubygems#2193 (review) and Improve package task. ______________ # Tasks: - [x] Describe the problem / feature - [x] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Followed up to remove old ruby versions. I did clean up redundant/deprecated sections on gemspec and travis.yml.
Tasks:
I will abide by the code of conduct.