Fix ruby warnings in test suite #2205
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnings in test suite
hsbt
approved these changes
Feb 23, 2018
|
@bundlerbot r+ |
|
📌 Commit 7f4951f has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Feb 23, 2018
Fix ruby warnings in test suite # Description: Running the rubygems test will print a couple of warnings, this PR fixes these warnings so we can have cleaner test output. ``` /Users/c/Projects/rubygems/test/rubygems/test_gem_package_tar_header.rb:161: warning: assigned but unused variable - new_header /Users/c/Projects/rubygems/test/rubygems/test_gem_server.rb:408: warning: character class has duplicated range /Users/c/Projects/rubygems/test/rubygems/test_gem_server.rb:463: warning: character class has duplicated range /Users/c/Projects/rubygems/test/rubygems/test_gem_server.rb:490: warning: character class has duplicated range /Users/c/Projects/rubygems/test/rubygems/test_gem_server.rb:517: warning: character class has duplicated range ``` The `\n` in `[\n\s]` is redundant because `\s` already includes `\n` # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
☀️ Test successful - status-travis |
hsbt
pushed a commit
that referenced
this pull request
Apr 28, 2018
Fix ruby warnings in test suite # Description: Running the rubygems test will print a couple of warnings, this PR fixes these warnings so we can have cleaner test output. ``` /Users/c/Projects/rubygems/test/rubygems/test_gem_package_tar_header.rb:161: warning: assigned but unused variable - new_header /Users/c/Projects/rubygems/test/rubygems/test_gem_server.rb:408: warning: character class has duplicated range /Users/c/Projects/rubygems/test/rubygems/test_gem_server.rb:463: warning: character class has duplicated range /Users/c/Projects/rubygems/test/rubygems/test_gem_server.rb:490: warning: character class has duplicated range /Users/c/Projects/rubygems/test/rubygems/test_gem_server.rb:517: warning: character class has duplicated range ``` The `\n` in `[\n\s]` is redundant because `\s` already includes `\n` # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Running the rubygems test will print a couple of warnings, this PR fixes these warnings so we can have cleaner test output.
The
\nin[\n\s]is redundant because\salready includes\nTasks:
I will abide by the code of conduct.