prefer to use util_spec in Gem::TestCase
#2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
approved these changes
Mar 10, 2018
| @@ -866,6 +867,19 @@ def util_spec name, version = 2, deps = nil # :yields: specification | |||
| end | |||
| end | |||
|
|
|||
| unless files.empty? then | |||
There was a problem hiding this comment.
should this check s.files instead?
There was a problem hiding this comment.
@segiddins s isn't defined at this point. (it'd be spec, here.)
@hsbt can you leave a comment here confirming whether or not this unless statement is correct?
if you confirm that's correct, lgtm.
There was a problem hiding this comment.
It is the different condition with spec.files. I tried to replace spec.files, after that some tests were failed.
I will go current implementation as first.
|
@bundlerbot r+ |
|
📌 Commit a33365b has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Mar 26, 2018
prefer to use util_spec in `Gem::TestCase` # Description: `Gem::Testcase` has `new_spec` and `util_spec` for building stub specification. I migrated them to util_spec and marked new_spec to deprecated. ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Gem::Testcasehasnew_specandutil_specfor building stub specification. I migrated them to util_spec and marked new_spec to deprecated.Tasks:
I will abide by the code of conduct.