Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed needless OpenSSL patch for Ruby 1.8. #2243

Merged
merged 1 commit into from Mar 23, 2018

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Mar 23, 2018

Description:

fix_openssl_warnings.rb is never used on master branch in the future.


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

@colby-swandale
Copy link
Member

Nice! @bundlerbot r+

@bundlerbot
Copy link
Collaborator

📌 Commit 5c92e13 has been approved by colby-swandale

@bundlerbot
Copy link
Collaborator

⌛ Testing commit 5c92e13 with merge a3e67e0...

bundlerbot added a commit that referenced this pull request Mar 23, 2018
…swandale

Removed needless OpenSSL patch for Ruby 1.8.

# Description:

`fix_openssl_warnings.rb` is never used on master branch in the future.
______________

# Tasks:

- [ ] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
@bundlerbot
Copy link
Collaborator

💔 Test failed - status-travis

@bundlerbot
Copy link
Collaborator

☀️ Test successful - status-travis
Approved by: colby-swandale
Pushing a3e67e0 to master...

@bundlerbot bundlerbot merged commit 5c92e13 into master Mar 23, 2018
@colby-swandale colby-swandale deleted the remove-needless-openssl-hack branch March 23, 2018 22:23
@colby-swandale colby-swandale added this to the 3.0 milestone Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants