Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport commits from ruby core #2347

Merged
merged 2 commits into from Jul 7, 2018
Merged

Backport commits from ruby core #2347

merged 2 commits into from Jul 7, 2018

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jul 7, 2018

Description:

Picked r63850 and r63851


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

znz added 2 commits July 7, 2018 17:31
Some tests are already skipped, but some tests are not.
So latter should be skipped too.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
`Gem::Package::TarWriter#add_file_signed` expects to fallback to
`Digest::SHA512`, and `digest.respond_to? :name` or not.
So lib/rubygems/security.rb should use same logic for
`Gem::Security::DIGEST_ALGORITHM` and `Gem::Security::DIGEST_NAME`.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@hsbt
Copy link
Member Author

hsbt commented Jul 7, 2018

@bundlerbot r+

@bundlerbot
Copy link
Collaborator

📌 Commit 9471f8e has been approved by hsbt

@bundlerbot
Copy link
Collaborator

⌛ Testing commit 9471f8e with merge 3710735...

bundlerbot added a commit that referenced this pull request Jul 7, 2018
Backport commits from ruby core

# Description:

Picked r63850 and r63851
______________

# Tasks:

- [ ] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
@bundlerbot
Copy link
Collaborator

☀️ Test successful - status-travis
Approved by: hsbt
Pushing 3710735 to master...

@bundlerbot bundlerbot merged commit 9471f8e into master Jul 7, 2018
@colby-swandale colby-swandale added this to the 2.7.8 milestone Sep 23, 2018
hsbt pushed a commit that referenced this pull request Oct 9, 2018
Backport commits from ruby core

# Description:

Picked r63850 and r63851
______________

# Tasks:

- [ ] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants