Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve certificate expiration defaults #2420

Merged
1 commit merged into from Oct 3, 2018

Conversation

bronzdoc
Copy link
Member

@bronzdoc bronzdoc commented Oct 3, 2018

Description:

closes #2397

This introduce a new configuration option cert_expiration_length_days, this option will allow a user to set the default expiration length in days of a certificate when is created or being re-signed.

.gemrc example:

:verbose: true
:update_sources: true
:backtrace: true
:cert_expiration_length_days: 30

I will abide by the code of conduct.

@bronzdoc
Copy link
Member Author

bronzdoc commented Oct 3, 2018

@bundlerbot r+

ghost pushed a commit that referenced this pull request Oct 3, 2018
2420: Improve certificate expiration defaults r=bronzdoc a=bronzdoc

# Description:

closes #2397

This introduce a new configuration option `cert_expiration_length_days`, this option will allow a user to set the default expiration length in days of a certificate when is created or being re-signed.

`.gemrc` example:
```yaml
:verbose: true
:update_sources: true
:backtrace: true
:cert_expiration_length_days: 30
```

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).

Co-authored-by: Luis Sagastume <lsagastume1990@gmail.com>
@ghost
Copy link

ghost commented Oct 3, 2018

Build succeeded

@ghost ghost merged commit aa2e84b into master Oct 3, 2018
@bronzdoc bronzdoc deleted the improve_certificate_expiration_defaults branch October 3, 2018 16:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security#re_sign should have smarter defaults
1 participant