Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundler-1.16.6 #2423

Merged
2 commits merged into from Nov 1, 2018
Merged

Update bundler-1.16.6 #2423

2 commits merged into from Nov 1, 2018

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Oct 5, 2018

Description:


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

@hsbt hsbt added this to the 2.7.8 milestone Oct 5, 2018
@colby-swandale
Copy link
Member

did i break something in this release?

@segiddins
Copy link
Member

Looks like a test just needs to handle not being in a git repo, or something?

@hsbt
Copy link
Member Author

hsbt commented Oct 6, 2018

@segiddins Yes, But Bundler-1.16.4 with RubyGems master passes the same example. Do we have some regression with Bundler-1.16.5 or 1.16.6?

@hsbt
Copy link
Member Author

hsbt commented Oct 6, 2018

Also failed #2429

@indirect
Copy link
Member

This is not a regression, but it's a change in the way that Bundler handles printing version numbers when Bundler itself is not inside a git repo. We can update the test 👍

@indirect
Copy link
Member

@hsbt @colby-swandale I fixed it! rubygems/bundler#6737 After we backport the commit to 1-16-stable, I think it's fine to update the submodule to point to that commit, rather than doing an entire Bundler release just for a fix that only works when Bundler is a submodule in RubyGems.

@hsbt
Copy link
Member Author

hsbt commented Oct 13, 2018

@indirect I agreed your suggestion. I will update submodule after updating to 1-16-stable branch in bundler and release rubygems 2.7.8.

@hsbt
Copy link
Member Author

hsbt commented Oct 25, 2018

@indirect @colby-swandale Still failing with 1-16-stable branch. I can release RG 2.7.8 with Bundler 1.16.6, But I hope to resolve this failure because it's also failing with Bundler 1.17.0 or 2.0.0.

@colby-swandale
Copy link
Member

Sorry for this to take so long @hsbt i will make this my number 1 issue to resolve.

@colby-swandale
Copy link
Member

I'm a bit confused as to what's happening here. The test is passing on my local machine and looking into the report on travis, it seems to be reporting for a different commit c6bdddd

@hsbt
Copy link
Member Author

hsbt commented Nov 1, 2018

@bundlerbot r+

ghost pushed a commit that referenced this pull request Nov 1, 2018
2423: Update bundler-1.16.6 r=hsbt a=hsbt

# Description:

______________

# Tasks:

- [ ] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
@ghost
Copy link

ghost commented Nov 1, 2018

Build succeeded

@ghost ghost merged commit 7c8aae3 into master Nov 1, 2018
@hsbt hsbt deleted the bundler-1-16-6 branch November 1, 2018 21:11
hsbt pushed a commit that referenced this pull request Nov 1, 2018
2423: Update bundler-1.16.6 r=hsbt a=hsbt

# Description:

______________

# Tasks:

- [ ] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
(cherry picked from commit fad97a1)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants