New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundler-1.16.6 #2423
Update bundler-1.16.6 #2423
Conversation
did i break something in this release? |
Looks like a test just needs to handle not being in a git repo, or something? |
@segiddins Yes, But Bundler-1.16.4 with RubyGems master passes the same example. Do we have some regression with Bundler-1.16.5 or 1.16.6? |
Also failed #2429 |
This is not a regression, but it's a change in the way that Bundler handles printing version numbers when Bundler itself is not inside a git repo. We can update the test 👍 |
@hsbt @colby-swandale I fixed it! rubygems/bundler#6737 After we backport the commit to |
@indirect I agreed your suggestion. I will update submodule after updating to |
@indirect @colby-swandale Still failing with |
Sorry for this to take so long @hsbt i will make this my number 1 issue to resolve. |
I'm a bit confused as to what's happening here. The test is passing on my local machine and looking into the report on travis, it seems to be reporting for a different commit c6bdddd |
1f5e9d1
to
7c8aae3
Compare
@bundlerbot r+ |
2423: Update bundler-1.16.6 r=hsbt a=hsbt # Description: ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
Build succeeded |
2423: Update bundler-1.16.6 r=hsbt a=hsbt # Description: ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org> (cherry picked from commit fad97a1)
Description:
Tasks:
I will abide by the code of conduct.