Move rubocop into a separate stage in travis ci #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colby-swandale
force-pushed
the
colby/travis-rubocop-build-stage
branch
from
4a2c28f
to
6b371ca
Compare
bronzdoc
approved these changes
Dec 5, 2018
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Dec 5, 2018
2510: Move rubocop into a separate stage in travis ci r=bronzdoc a=colby-swandale # Description: TIL it's now possible to use multiple stages in Travis-CI while using the `rvm` matrix. With that, this PR moves rubocop into it's own stage - before any tests are executed. This should provide faster feedback to contributors and make a clear separation between linting and tests. Here's an [example build](https://travis-ci.org/rubygems/rubygems/builds/463775265) (this failed because it was a custom build that didn't have the changes to run rubocop by itself). The build for this PR should use the separate stages as well. ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Colby Swandale <me@colby.fyi>
Build succeeded |
ghost
merged commit
ghost
pushed a commit
to rubygems/bundler
that referenced
this pull request
Dec 6, 2018
6830: move rubocop into a separate stage in Travis-CI r=deivid-rodriguez a=colby-swandale ## Overview This PR is pretty much a copy of rubygems/rubygems#2510. It moves rubocop into a separate stage that is run before any tests are executed. This will allow for faster feedback and mean that we don't have to run rubocop on all our available instances in Travis. Co-authored-by: Colby Swandale <me@colby.fyi>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
TIL it's now possible to use multiple stages in Travis-CI while using the
rvmmatrix. With that, this PR moves rubocop into it's own stage - before any tests are executed. This should provide faster feedback to contributors and make a clear separation between linting and tests.Here's an example build (this failed because it was a custom build that didn't have the changes to run rubocop by itself). The build for this PR should use the separate stages as well.
Tasks:
I will abide by the code of conduct.