Restore SOURCE_DATE_EPOCH #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66554 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Dec 31, 2018
2560: Restore SOURCE_DATE_EPOCH r=hsbt a=hsbt # Description: Fixes #2551 and Rleated #2552 ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>
Build succeeded |
ghost
merged commit 
|
I think this changes nothing because RubyGems::TestCase already has environment variable restoration logic in |
hsbt
pushed a commit
that referenced
this pull request
Jan 1, 2019
2560: Restore SOURCE_DATE_EPOCH r=hsbt a=hsbt # Description: Fixes #2551 and Rleated #2552 ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> (cherry picked from commit 29bdf2a)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #2551 and Rleated #2552
Tasks:
I will abide by the code of conduct.