test_gem.rb - intermittent failure fix #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assert_self_install_permissions File.open -> File.write ?
|
seems good. Thanks. |
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Jan 31, 2019
2613: test_gem.rb - intermittent failure fix r=hsbt a=MSP-Greg # Description: Update assert_self_install_permissions method to hopefully stop intermittent failures File.open -> File.write, move directory creation to top # Tasks: - [X] Describe the problem / feature - [ ] Write tests - [X] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: MSP-Greg <greg.mpls@gmail.com>
|
A little off topic. Seeing the 'allow failure' in trunk on Travis, I noticed that Travis CI is using Trusty/14.04, which uses OpenSSL 1.0.1 (EOL 2016-12?). Are you ok with updating to Xenial/16.04 (OpenSSL 1.0.2)? |
Build succeeded |
ghost
merged commit
|
@MSP-Greg It's welcomed if it resolves failure status of ruby-trunk on Travis. |
|
Add 2.6.0 ? If yes, both 'rubygems' & 'bundler'? |
|
Just saw the failures in Appveyor & Travis. I give up. The only thing left is more timeouts within the 'create folders'/'create files' code... Running Xenial & 2.6.0 in my fork right now... |
4 tasks
hsbt
pushed a commit
that referenced
this pull request
Jun 13, 2019
2613: test_gem.rb - intermittent failure fix r=hsbt a=MSP-Greg # Description: Update assert_self_install_permissions method to hopefully stop intermittent failures File.open -> File.write, move directory creation to top # Tasks: - [X] Describe the problem / feature - [ ] Write tests - [X] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: MSP-Greg <greg.mpls@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update assert_self_install_permissions method to hopefully stop intermittent failures
File.open -> File.write, move directory creation to top
Tasks:
I will abide by the code of conduct.