Downgrade bundler mismatches to a warning (2nd try) #2696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
I super-confused now about this build being green. |
deivid-rodriguez
force-pushed
the
downgrade_bundler_mismatches_to_a_warning
branch
from
3996649
to
7304483
Compare
|
Ok, I fixed the test failures although one of the fixes feels just like a workaround. I'll think of a better fix tomorrow. |
4 tasks
deivid-rodriguez
force-pushed
the
downgrade_bundler_mismatches_to_a_warning
branch
2 times, most recently
from
f47943a
to
5412215
Compare
deivid-rodriguez
force-pushed
the
downgrade_bundler_mismatches_to_a_warning
branch
2 times, most recently
from
6448974
to
745f540
Compare
So that specs keep passing under bundler's master.
deivid-rodriguez
force-pushed
the
downgrade_bundler_mismatches_to_a_warning
branch
2 times, most recently
from
4aa6698
to
720f965
Compare
4 tasks
4 tasks
|
Closing in favor of #5181. |
deivid-rodriguez
deleted the
downgrade_bundler_mismatches_to_a_warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Supersedes #2621.
Tasks:
I will abide by the code of conduct.