Expose windows path normalization utility #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need this exact piece of logic in bundler, so I guess we should move it to some place where it makes more sense to reuse it.
deivid-rodriguez
force-pushed
the
expose_windows_path_normalization
branch
from
2cd716c
to
871dfc5
Compare
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
May 28, 2019
2767: Expose windows path normalization utility r=hsbt a=deivid-rodriguez # Description: I need this exact piece of logic in `bundler` (rubygems/bundler#7161 (comment)), so I guess we should move it to some place where it makes more sense to reuse it. I don't have a strong opinion though, maybe it's better to not bother and duplicate the logic. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit 
hsbt
pushed a commit
that referenced
this pull request
Aug 16, 2019
2767: Expose windows path normalization utility r=hsbt a=deivid-rodriguez # Description: I need this exact piece of logic in `bundler` (rubygems/bundler#7161 (comment)), so I guess we should move it to some place where it makes more sense to reuse it. I don't have a strong opinion though, maybe it's better to not bother and duplicate the logic. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I need this exact piece of logic in
bundler(rubygems/bundler#7161 (comment)), so I guess we should move it to some place where it makes more sense to reuse it.I don't have a strong opinion though, maybe it's better to not bother and duplicate the logic.
Tasks:
I will abide by the code of conduct.