-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Gem::Specification#ruby_code handle OpenSSL::PKey::RSA objects #2782
Conversation
That seems fine to me, but I suspect this is used to serialize specs still. Skipping outright might be a better option... I'd want someone more in the know to weigh in on that. I haven't maintained rubygems in ages. But for MY purposes, as long as it doesn't crash I'm happy. |
Also, thank you. That was very timely. |
I would vote for completely skipping this field too. As far as I know, this is only used at |
Removing the signing key trigger a couple of errors, and made me notice we are printing the when Array then '[' + obj.map { |x| ruby_code x }.join(", ") + ']'¬ so kinda the output we want to avoid by not doing |
4c5e8c5
to
e7a340f
Compare
Build failures are not related to this change, I don't understand why travis is having issues with bundler in this particular PR 🤔 |
The tests know how much I hate bundler and are getting back at me. 🙁 |
I think this may be the result of the older version of bundler currently being used. I believe the changes in rubygems/bundler@e742c3d / rubygems/bundler#7100 will fix this. But, it breaks Ruby master/trunk/ruby-head builds when they are used for CI testing. That fix is at rubygems/bundler#7248 |
e7a340f
to
0427656
Compare
... status? There's been 4 releases since this came up... |
0427656
to
ba021fb
Compare
@bundlerbot r+ |
2782: Make Gem::Specification#ruby_code handle OpenSSL::PKey::RSA objects r=bronzdoc a=bronzdoc # Description: closes #2776 @zenspider what you think? ______________ I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
Build succeeded |
2782: Make Gem::Specification#ruby_code handle OpenSSL::PKey::RSA objects r=bronzdoc a=bronzdoc # Description: closes #2776 @zenspider what you think? ______________ I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
Description:
closes #2776
@zenspider what you think?
I will abide by the code of conduct.