Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for 'gem env packageversion' #2813

Merged
1 commit merged into from Jul 10, 2019
Merged

Drop support for 'gem env packageversion' #2813

1 commit merged into from Jul 10, 2019
+0 −55

Conversation

bronzdoc
Copy link
Member

Description:

gem env packageversion support should have dropped in Rubygems 3.0

I will abide by the code of conduct.

@bronzdoc bronzdoc requested a review from hsbt June 27, 2019 02:51
@deivid-rodriguez
Copy link
Member

@bronzdoc Tests fail because you need to update the manifest. I'll open a PR to make this test error more actionable.

@bronzdoc bronzdoc force-pushed the drop_packageversion_support branch 2 times, most recently from dd2f499 to 8c0f4b6 Compare June 28, 2019 05:59
@bronzdoc
Copy link
Member Author

bronzdoc commented Jun 30, 2019 •
edited

🤔 i'm not sure why this is still failing

@simi
Copy link
Member

simi commented Jun 30, 2019

@bronzdoc the problem in here is that bundler/man/bundle-add.1 file (and all added to manifest in this pull request) are created during rake man:build in bundler repo. The failure is complaining about those missing files. I think those files should be removed from Manifest.txt or being versioned in bundler repository.

@deivid-rodriguez
Copy link
Member

Yeah, you need to remove those files (git clean -fx from bundler's folder). and regenerate the manifest.

I think we could improve this in bundler by removing those generated files automatically after tests run (they do some sanity checks on rake man:build), and after rake build runs. I'll open a PR on bundler to do that.

@deivid-rodriguez deivid-rodriguez mentioned this pull request Jul 4, 2019
Closed
deivid-rodriguez
deivid-rodriguez approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the failing build, this looks good to me! 👍

simi
simi approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@simi simi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bronzdoc feel free to ping me if you need help getting green build, I can send PR to your branch.

@bronzdoc bronzdoc force-pushed the drop_packageversion_support branch from 8c0f4b6 to be962ca Compare July 10, 2019 13:17
@bronzdoc
Copy link
Member Author

Thanks for the review folks :)

@bundlerbot r+

ghost pushed a commit that referenced this pull request Jul 10, 2019
@bundlerbot @bronzdoc
Merge #2813
65cd52c 
2813: Drop support for 'gem env packageversion' r=bronzdoc a=bronzdoc

# Description:
`gem env packageversion` support should have dropped in Rubygems 3.0
______________
I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).

Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
@ghost
Copy link

ghost commented Jul 10, 2019

Build succeeded

@ghost ghost merged commit be962ca into master Jul 10, 2019
@ghost ghost deleted the drop_packageversion_support branch July 10, 2019 14:35
@bronzdoc bronzdoc added this to the 3.0.5 milestone Jul 16, 2019
hsbt pushed a commit that referenced this pull request Aug 16, 2019
@bundlerbot @bronzdoc @hsbt
Merge #2813
00df9ec 
2813: Drop support for 'gem env packageversion' r=bronzdoc a=bronzdoc

# Description:
`gem env packageversion` support should have dropped in Rubygems 3.0
______________
I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).

Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
hsbt added a commit that referenced this pull request Aug 16, 2019
@hsbt
Revert "Merge #2813"
8205941 
This reverts commit 00df9ec.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simi simi simi approved these changes

@deivid-rodriguez deivid-rodriguez deivid-rodriguez approved these changes

@hsbt hsbt Awaiting requested review from hsbt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bronzdoc @deivid-rodriguez @simi