Remove TODO comment about warning on setting instead of pushing #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If only specs are related to this, I think we should think about removing/deprecating those methods. |
|
@simi if we deprecate/remove those methods people will have to modify their gemspecs to use |
|
This looks good to me, although I initially interpreted "specs" as referring to tests instead of gemspecs, which confused me for a moment. Realistically, I don't think these can be deprecated at this point. It'd break a ton of gemspecs in the wild. @bronzdoc is there a reason this is marked as wip, or is it good to go? |
|
@duckinator I did the same mistake, sorry. |
simi
approved these changes
Dec 7, 2019
duckinator
approved these changes
Dec 7, 2019
|
|
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Dec 7, 2019
2823: Remove TODO comment about warning on setting instead of pushing r=bronzdoc a=bronzdoc # Description: Remove TODO comment about warning on setting instead of pushing. This methods are heavily used across specs and i personally think those warning at this point will not add much value, thoughts? ______________ I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
Build succeeded
|
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove TODO comment about warning on setting instead of pushing.
This methods are heavily used across specs and i personally think those warning at this point will not add much value, thoughts?
I will abide by the code of conduct.