Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FIXME comment related to PathSupport #2854

Merged
1 commit merged into from Jul 31, 2019
Merged

Conversation

bronzdoc
Copy link
Member

Description:

Followup #2851

cc @simi


I will abide by the code of conduct.

@bronzdoc
Copy link
Member Author

@bundlerbot r+

ghost pushed a commit that referenced this pull request Jul 30, 2019
2854: Remove FIXME comment related to PathSupport r=bronzdoc a=bronzdoc

# Description:
Followup #2851

cc @simi 
______________

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
@ghost
Copy link

ghost commented Jul 30, 2019

Build failed

@bronzdoc
Copy link
Member Author

@bundlerbot retry

ghost pushed a commit that referenced this pull request Jul 30, 2019
2854: Remove FIXME comment related to PathSupport r=bronzdoc a=bronzdoc

# Description:
Followup #2851

cc @simi 
______________

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
@ghost
Copy link

ghost commented Jul 30, 2019

Build failed

@bronzdoc
Copy link
Member Author

@bundlerbot retry

4 similar comments
@bronzdoc
Copy link
Member Author

@bundlerbot retry

@bronzdoc
Copy link
Member Author

@bundlerbot retry

@bronzdoc
Copy link
Member Author

@bundlerbot retry

@bronzdoc
Copy link
Member Author

@bundlerbot retry

@bronzdoc
Copy link
Member Author

@bundlerbot r+

@ghost
Copy link

ghost commented Jul 31, 2019

Not awaiting review

ghost pushed a commit that referenced this pull request Jul 31, 2019
2854: Remove FIXME comment related to PathSupport r=bronzdoc a=bronzdoc

# Description:
Followup #2851

cc @simi 
______________

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
@ghost
Copy link

ghost commented Jul 31, 2019

Build failed

@hsbt
Copy link
Member

hsbt commented Jul 31, 2019

@bundlerbot r+

ghost pushed a commit that referenced this pull request Jul 31, 2019
2854: Remove FIXME comment related to PathSupport r=hsbt a=bronzdoc

# Description:
Followup #2851

cc @simi 
______________

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
@ghost
Copy link

ghost commented Jul 31, 2019

Build succeeded

@ghost ghost merged commit 5a1d3d6 into master Jul 31, 2019
@ghost ghost deleted the remove-fixme-comment branch July 31, 2019 04:05
@hsbt hsbt added this to the 3.0.5 milestone Aug 16, 2019
hsbt pushed a commit that referenced this pull request Aug 16, 2019
2854: Remove FIXME comment related to PathSupport r=hsbt a=bronzdoc

# Description:
Followup #2851

cc @simi 
______________

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
hsbt pushed a commit that referenced this pull request Aug 16, 2019
2854: Remove FIXME comment related to PathSupport r=hsbt a=bronzdoc

# Description:
Followup #2851

cc @simi 
______________

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants