Simplify deprecate command method #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bronzdoc
changed the title
deivid-rodriguez
requested changes
Nov 1, 2019
|
@bronzdoc woah, this is a great improvement, nicely done! After you add the test @deivid-rodriguez mentioned, I think this is good to go! |
bronzdoc
force-pushed
the
simplify-deprecate-comamnd-method
branch
from
3235920
to
e9e7c38
Compare
deivid-rodriguez
approved these changes
Nov 18, 2019
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Nov 19, 2019
2974: Simplify deprecate command method r=deivid-rodriguez a=bronzdoc # Description: Simplify `Gem::Deprecate#deprecate_command` that was introduced here #2935 ______________ I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
Build succeeded
|
ghost
merged commit 
5 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Simplify
Gem::Deprecate#deprecate_commandthat was introduced here #2935I will abide by the code of conduct.