Fix CI against bundler's master #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current run seems to be failing. I'm not sure exactly why, but using a "more standard" trick for redefining the method seems to fix it.
|
@bundlerbot try |
tryBuild succeeded
|
4 similar comments
tryBuild succeeded
|
tryBuild succeeded
|
tryBuild succeeded
|
tryBuild succeeded
|
|
Ok, @bundlerbot merge |
ghost
pushed a commit
that referenced
this pull request
Dec 7, 2019
3021: Fix CI against bundler's master r=deivid-rodriguez a=deivid-rodriguez # Description: Current run seems to be failing. I'm not sure exactly why. Nothing has changed in `bundler` in the last few days, so maybe it's order dependent, and now I tried this order way of doing it and it passed... 🤷♂️ # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
tryBuild succeeded
|
1 similar comment
tryBuild succeeded
|
Build succeeded
|
ghost
merged commit
tryBuild succeeded
|
3 similar comments
tryBuild succeeded
|
tryBuild succeeded
|
tryBuild succeeded
|
tryTimed out |
hsbt
pushed a commit
that referenced
this pull request
Dec 13, 2019
3021: Fix CI against bundler's master r=deivid-rodriguez a=deivid-rodriguez # Description: Current run seems to be failing. I'm not sure exactly why. Nothing has changed in `bundler` in the last few days, so maybe it's order dependent, and now I tried this order way of doing it and it passed... 🤷♂️ # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Current run seems to be failing. I'm not sure exactly why. Nothing has changed in
bundlerin the last few days, so maybe it's order dependent, and now I tried this order way of doing it and it passed... 🤷♂️Tasks:
I will abide by the code of conduct.