Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --platform option to build command #3079

Merged
merged 3 commits into from
Aug 6, 2020

Conversation

nobu
Copy link
Contributor

@nobu nobu commented Jan 10, 2020

Description:

@headius wrote at ruby/io-console#11 (comment):

One bit of process I'm not sure about: this -java gem can only be built with JRuby, and likewise the standard gem can't be build on JRuby, because the gemspec uses RUBY_ENGINE. This could be modified to allow building both versions on any impl, since they're just packaging files (i.e. there's no compile step required for either JRuby or MRI).


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

@hsbt hsbt self-assigned this Aug 6, 2020
@hsbt hsbt merged commit 06effc3 into rubygems:master Aug 6, 2020
@hsbt hsbt added this to the 3.2.0 milestone Aug 7, 2020
hsbt added a commit that referenced this pull request Sep 23, 2020
Added `--platform` option to `build` command
@nobu nobu deleted the build--platform-option branch June 4, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants