Fix error when trying to find bundler with a deleted "working directo… #3090

bronzdoc · 2020-01-21T05:27:03Z

Description:

Fix and error in the Bundler version finder when run in a deleted current working directory

…ry" - `pwd': No such file or directory - getcwd (Errno::ENOENT)

asf-stripe

Thanks for putting in a super quick fix to this! I left some comments from that I gathered as I investigated this issue - please use or discard them as you see fit (:

asf-stripe · 2020-01-21T15:55:29Z

test/rubygems/test_gem_bundler_version_finder.rb

+      Dir.chdir(dir)
+    end
+
+    assert_nil bvf.bundler_version_with_reason


I think this test probably should chdir back to its old dir, otherwise the other tests are going to have a hard time / fail in an order-dependent way.

@bronzdoc can you elaborate on why you marked this as resolved? I have the same concern as @asf-stripe, but I may be missing some context. (E.g., does the setup process run before each test call Dir.chdir, or something like that?)

Thanks both of you! I fixed it. It will restore to the original PWD, somehow I thought I was passing that block to Dir.chdir...

lib/rubygems/bundler_version_finder.rb

bronzdoc · 2020-01-26T13:38:34Z

For some reason the CI Windows environment can't delete the tmpdir of the test I added for this change - Errno::EACCES: Permission denied @ dir_s_rmdir - C:/Users/RUNNER~1/AppData/Local/Temp/d20200125-5128-70ojio

@MSP-Greg Have this happened to you in the past? maybe you can point me to the right track 🙇

MSP-Greg · 2020-01-26T15:19:16Z

@bronzdoc

Have this happened to you in the past?

Similar. I've debated whether to track down the issue or not.

Windows uses TEMP and TMP for ENV settings to get the temp folder. The path is C:/Users/runneradmin/AppData/Local/Temp, but since runneradmin is a 'long path name', it's 'short name' of RUNNER~1 is used, probably for compatibility with legacy apps.

What I've done when it's an issue is set TMPDIR to a folder. TMPDIR is the first ENV value checked by Ruby. From years ago, I've also set up my local systems that way...

Maybe something like:

      - name: Run Test
        run: |
          mkdir temp
          $env:TMPDIR = "$pwd/temp"
          ridk enable
          rake test

MSP-Greg · 2020-01-26T18:27:17Z

@bronzdoc

I just looked at the test that's causing the issue.

On Windows, one can't delete the dir that is $pwd / Dir.pwd. Nothing to do with temp files or directories...

bronzdoc · 2020-01-26T18:32:08Z

Thanks so much for looking into this @MSP-Greg!
I guess I would have to explicitly create and remove a dir to test this then. 🤷‍♂

MSP-Greg · 2020-01-26T18:55:37Z

@bronzdoc

I'm probably missing something, but I think the test won't work on Windows and, hence, needs to be skipped.

As one can't delete $pwd, one also can't Dir.chdir into a non-existent directory...

…pwd/Dir.pwd. Nothing to do with temp files or directories

duckinator

This looks good to me, aside from the same issue that was mentioned by @asf-stripe — I'm wondering if you may need to Dir.chdir back to where it was prior to the test running.

duckinator · 2020-02-04T19:44:58Z

test/rubygems/test_gem_bundler_version_finder.rb

+      Dir.chdir(dir)
+    end
+
+    assert_nil bvf.bundler_version_with_reason


@bronzdoc can you elaborate on why you marked this as resolved? I have the same concern as @asf-stripe, but I may be missing some context. (E.g., does the setup process run before each test call Dir.chdir, or something like that?)

bronzdoc · 2020-02-13T14:27:00Z

@bundlerbot r+

3090: Fix error when trying to find bundler with a deleted "working directo… r=bronzdoc a=bronzdoc closes #3087 # Description: Fix and error in the Bundler version finder when run in a deleted `current working directory` ______________ I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). 3127: Refactor ruby path finding r=bronzdoc a=deivid-rodriguez # Description: We have some duplicated logic to find out the fullpath to the ruby binary. I think `RbConfig.ruby` can be fully trusted as the source of truth for this information. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: bronzdoc <lsagastume1990@gmail.com> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

ghost · 2020-02-13T15:37:44Z

Build succeeded

install (2.3.8)
install (2.4.9)
install (2.5.7)
install (2.6.5)
install (jruby-9.2.9.0)
macos (2.4.x)
macos (2.5.x)
macos (2.6.x)
ruby_master
ubuntu (2.4.x, bundler)
ubuntu (2.4.x, rubygems)
ubuntu (2.5.x, bundler)
ubuntu (2.5.x, rubygems)
ubuntu (2.6.x, bundler)
ubuntu (2.6.x, rubygems)
ubuntu_bundler_master (2.6.x)
ubuntu_lint
ubuntu_rvm (2.3.8)
ubuntu_rvm (jruby-9.2.9.0)
ubuntu_rvm (ruby-head)
windows (2.4.x)
windows (2.5.x)
windows (2.6.x)

Fix error when trying to find bundler with a deleted "working directo…

a13d246

…ry" - `pwd': No such file or directory - getcwd (Errno::ENOENT)

bronzdoc added status: triage wip labels Jan 21, 2020

bronzdoc force-pushed the fix/bundler-version-finder-pwd branch from 8e73b30 to a13d246 Compare January 21, 2020 14:12

asf-stripe reviewed Jan 21, 2020

View reviewed changes

Return if we get 'Errno::ENOENT'

963965f

bronzdoc force-pushed the fix/bundler-version-finder-pwd branch from 4187449 to e4df2de Compare January 25, 2020 01:54

Skip test for Windows. On Windows, one can't delete the dir that is $…

0eb98af

…pwd/Dir.pwd. Nothing to do with temp files or directories

bronzdoc force-pushed the fix/bundler-version-finder-pwd branch from e4df2de to 0eb98af Compare January 31, 2020 20:16

bronzdoc removed the wip label Feb 1, 2020

bronzdoc requested review from deivid-rodriguez, duckinator and hsbt February 4, 2020 13:37

duckinator reviewed Feb 4, 2020

View reviewed changes

Restore the original PWD

ad5bff2

ghost merged commit ad5bff2 into master Feb 13, 2020

ghost deleted the fix/bundler-version-finder-pwd branch February 13, 2020 15:37

bronzdoc removed the status: triage label Feb 13, 2020

Irakaj93 mentioned this pull request Dec 26, 2020

Error occurs everytime i try to create a new rails app #4197

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix error when trying to find bundler with a deleted "working directo… #3090

Fix error when trying to find bundler with a deleted "working directo… #3090

bronzdoc commented Jan 21, 2020

asf-stripe left a comment

asf-stripe Jan 21, 2020

duckinator Feb 4, 2020 •

edited

Loading

bronzdoc Feb 13, 2020

bronzdoc commented Jan 26, 2020

MSP-Greg commented Jan 26, 2020

MSP-Greg commented Jan 26, 2020

bronzdoc commented Jan 26, 2020

MSP-Greg commented Jan 26, 2020

duckinator left a comment

duckinator Feb 4, 2020 •

edited

Loading

bronzdoc commented Feb 13, 2020

ghost commented Feb 13, 2020

Fix error when trying to find bundler with a deleted "working directo… #3090

Fix error when trying to find bundler with a deleted "working directo… #3090

Conversation

bronzdoc commented Jan 21, 2020

Description:

asf-stripe left a comment

Choose a reason for hiding this comment

asf-stripe Jan 21, 2020

Choose a reason for hiding this comment

duckinator Feb 4, 2020 • edited Loading

Choose a reason for hiding this comment

bronzdoc Feb 13, 2020

Choose a reason for hiding this comment

bronzdoc commented Jan 26, 2020

MSP-Greg commented Jan 26, 2020

MSP-Greg commented Jan 26, 2020

bronzdoc commented Jan 26, 2020

MSP-Greg commented Jan 26, 2020

duckinator left a comment

Choose a reason for hiding this comment

duckinator Feb 4, 2020 • edited Loading

Choose a reason for hiding this comment

bronzdoc commented Feb 13, 2020

ghost commented Feb 13, 2020

Build succeeded

duckinator Feb 4, 2020 •

edited

Loading

duckinator Feb 4, 2020 •

edited

Loading