Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ubygems.rb #3102

Merged
1 commit merged into from
Jan 30, 2020
Merged

Remove ubygems.rb #3102

1 commit merged into from
Jan 30, 2020

Conversation

bronzdoc
Copy link
Member

Description:

Remove ubygems.rb


I will abide by the code of conduct.

@simi
Copy link
Member

simi commented Jan 26, 2020

🤔 it was removed form ruby some time ago - ruby/ruby@e5e1f90. Wondering why it is still present in this repo.

@hsbt hsbt self-assigned this Jan 27, 2020
@hsbt
Copy link
Member

hsbt commented Jan 30, 2020

@simi I removed ubygems.rb at Ruby 2.5. But I skip to remove it on rubygems repository because of rubygems-update need to support < Ruby 2.5 at its time.

In this year, Ruby 2.4 will be EOL status. We can remove it in 2020.

@hsbt
Copy link
Member

hsbt commented Jan 30, 2020

@bundlerbot merge

ghost pushed a commit that referenced this pull request Jan 30, 2020
3102: Remove ubygems.rb r=hsbt a=bronzdoc

# Description:

Remove `ubygems.rb`
______________

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


3103: Remove Gem::Installer#extension_build_error r=hsbt a=bronzdoc

# Description:

Remove deprecated method `Gem::Installer#extension_build_error`
______________

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
@ghost
Copy link

ghost commented Jan 30, 2020

Build succeeded

  • install (2.3.8)
  • install (2.4.9)
  • install (2.5.7)
  • install (2.6.5)
  • install (jruby-9.2.9.0)
  • macos (2.4.x)
  • macos (2.5.x)
  • macos (2.6.x)
  • ruby_master
  • ubuntu (2.4.x, bundler)
  • ubuntu (2.4.x, rubygems)
  • ubuntu (2.5.x, bundler)
  • ubuntu (2.5.x, rubygems)
  • ubuntu (2.6.x, bundler)
  • ubuntu (2.6.x, rubygems)
  • ubuntu_bundler_master (2.6.x)
  • ubuntu_lint
  • ubuntu_rvm (2.3.8)
  • ubuntu_rvm (jruby-9.2.9.0)
  • ubuntu_rvm (ruby-head)
  • windows (2.4.x)
  • windows (2.5.x)
  • windows (2.6.x)

@ghost ghost merged commit 7ac54d5 into master Jan 30, 2020
@ghost ghost deleted the remove-ubygems-file branch January 30, 2020 07:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants