Remove Gem::Commands::QueryCommand #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bronzdoc
force-pushed
the
remove-query-command
branch
from
afcdca1
to
b19c53f
Compare
|
@bundlerbot merge |
ghost
pushed a commit
that referenced
this pull request
Jan 27, 2020
3104: Remove Gem::Commands::QueryCommand r=hsbt a=bronzdoc # Description: Remove deprecated command `Gem::Commands::QueryCommand` ______________ I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
Build succeeded
|
ghost
merged commit 
|
This PR is most likely a mistake. We only deprecated this command 2 months ago, and we haven't yet released the deprecation to our end users, so nobody knows that we deprecated the command. This is the reason why I opened #3013, because with the current system it's very easy to deprecate something and remove it within the same release, which is the exact same thing as abruptly removing it. |
|
Ah, It's reasonable. We should revert this and reapply in the next year. |
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 2, 2020
hsbt
added a commit
that referenced
this pull request
Feb 3, 2020
ghost
pushed a commit
that referenced
this pull request
Feb 3, 2020
3119: Restore gem query r=hsbt a=deivid-rodriguez # Description: Restores `gem query` command and sets removal date to next year, since we never actually released the deprecation, as per #3104 (comment). # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove deprecated command
Gem::Commands::QueryCommandI will abide by the code of conduct.