Remove source_exception from Gem::Exception #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bundlerbot merge |
ghost
pushed a commit
that referenced
this pull request
Jan 29, 2020
3112: Remove source_exception from Gem::Exception r=hsbt a=bronzdoc # Description: Remove `deprecated source_exception` accessor from Gem::Exception ______________ I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). 3113: Remove functionality to create an Gem::Installer object with a string r=hsbt a=bronzdoc # Description: This deprecation warning has been showing since `2015` ```shell de3f8d0 lib/rubygems/installer.rb (Aaron Patterson 2015-04-10 14:20:44 -0700 187) warn "constructing an Installer object with a string is deprecated. Please use Gem::Installer.at (called from: #{caller.first})" ``` Maybe it's time to actually remove functionality to create `Gem::Installer` objects with a string. ______________ I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
Build succeeded
|
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove
deprecated source_exceptionaccessor from Gem::ExceptionI will abide by the code of conduct.