Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requiring rubygems/source_specific_file is deprecated, remove it. #3114

Merged
1 commit merged into from Jan 28, 2020

Conversation

bronzdoc
Copy link
Member

Description:

This deprecation has been showing since 2017

d1f199be8 (Ellen Marie Dash 2017-06-03 17:27:39 -0400 5)   Kernel.warn "#{Gem.location_of_caller(3).join(':')}: Warning: Requiring rubygems/source_specific_file is deprecated; please use rubygems/source/specific_file instead."

I will abide by the code of conduct.

@hsbt
Copy link
Member

hsbt commented Jan 28, 2020

Good catch!

@bundlerbot merge

ghost pushed a commit that referenced this pull request Jan 28, 2020
3114: Requiring rubygems/source_specific_file is deprecated, remove it. r=hsbt a=bronzdoc

# Description:

This deprecation has been showing since `2017`

```
d1f199b (Ellen Marie Dash 2017-06-03 17:27:39 -0400 5)   Kernel.warn "#{Gem.location_of_caller(3).join(':')}: Warning: Requiring rubygems/source_specific_file is deprecated; please use rubygems/source/specific_file instead."
```
______________

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
@hsbt hsbt self-assigned this Jan 28, 2020
@ghost
Copy link

ghost commented Jan 28, 2020

Build succeeded

  • install (2.3.8)
  • install (2.4.9)
  • install (2.5.7)
  • install (2.6.5)
  • install (jruby-9.2.9.0)
  • macos (2.4.x)
  • macos (2.5.x)
  • macos (2.6.x)
  • ruby_master
  • ubuntu (2.4.x, bundler)
  • ubuntu (2.4.x, rubygems)
  • ubuntu (2.5.x, bundler)
  • ubuntu (2.5.x, rubygems)
  • ubuntu (2.6.x, bundler)
  • ubuntu (2.6.x, rubygems)
  • ubuntu_bundler_master (2.6.x)
  • ubuntu_lint
  • ubuntu_rvm (2.3.8)
  • ubuntu_rvm (jruby-9.2.9.0)
  • ubuntu_rvm (ruby-head)
  • windows (2.4.x)
  • windows (2.5.x)
  • windows (2.6.x)

@ghost ghost merged commit ec4dd77 into master Jan 28, 2020
@ghost ghost deleted the remove-source-specific-file branch January 28, 2020 08:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants