Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve latest version via gem contents #3149

Merged
2 commits merged into from
Feb 24, 2020
Merged

Conversation

dnrce
Copy link
Contributor

@dnrce dnrce commented Feb 21, 2020

Description:

Issue

Scenario: I have two versions of gem foo installed.
Current behavior: gem contents foo returns information about the older version.
Expected behavior: gem contents foo returns information about the newer version.


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

@welcome
Copy link

welcome bot commented Feb 21, 2020

Thanks for opening a pull request and helping make RubyGems better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Github Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Github Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

lib/rubygems/commands/contents_command.rb Outdated Show resolved Hide resolved
lib/rubygems/commands/contents_command.rb Outdated Show resolved Hide resolved
@dnrce dnrce changed the title Resolve expected "best" version via gem contents Resolve latest version via gem contents Feb 24, 2020
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing this! 💜

@bronzdoc
Copy link
Member

@bundlerbot merge

@ghost
Copy link

ghost commented Feb 24, 2020

Build succeeded

  • install (2.3.8)
  • install (2.4.9)
  • install (2.5.7)
  • install (2.6.5)
  • install (jruby-9.2.9.0)
  • macos (2.4.9)
  • macos (2.5.7)
  • macos (2.6.5)
  • ubuntu (2.3.8, rubygems)
  • ubuntu (2.4.9, bundler)
  • ubuntu (2.4.9, rubygems)
  • ubuntu (2.5.7, bundler)
  • ubuntu (2.5.7, rubygems)
  • ubuntu (2.6.5, bundler)
  • ubuntu (2.6.5, rubygems)
  • ubuntu_bundler_master (2.6.5)
  • ubuntu (jruby-9.2.9.0, rubygems)
  • ubuntu_lint
  • unstable (ruby-head)
  • windows (2.4.9)
  • windows (2.5.7)
  • windows (2.6.5)

@ghost ghost merged commit 43cabdf into rubygems:master Feb 24, 2020
@dnrce dnrce deleted the contents_version branch February 24, 2020 20:56
@dnrce
Copy link
Contributor Author

dnrce commented Feb 24, 2020

Thanks, all, for the review!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants