Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bundle config --local docs clearer #3408

Merged
merged 1 commit into from
Mar 21, 2020

Conversation

kevinburke1
Copy link
Contributor

The previous references to "app" could easily be confused with the
"app" directory of a Rails project, leading people to look in the
wrong place for Bundler configuration. Instead use a variable that
should make it clearer that we mean the top level of the project.

Fixes #3385.

I will abide by the code of conduct.

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 💯

@deivid-rodriguez deivid-rodriguez changed the title bundler/man: make bundler config --local docs clearer Make bundle config --local docs clearer Mar 20, 2020
The previous references to "app" could easily be confused with the
"app" directory of a Rails project, leading people to look in the
wrong place for Bundler configuration. Instead use a variable that
should make it clearer that we mean the top level of the project.

Fixes rubygems#3385.
@deivid-rodriguez deivid-rodriguez merged commit d3c0bb9 into rubygems:master Mar 21, 2020
@deivid-rodriguez
Copy link
Member

Thanks so much for fixing this! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"bundle config --local path 'vendor/bundle'" takes no action
3 participants