Accept not only /usr/bin/env but also /bin/env in some tests #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubyGems chooses available one from the two: /usr/bin/env or /bin/env https://github.com/rubygems/rubygems/blob/20b0d609484df2b514954ba9ef890a7cbdd01d18/lib/rubygems/installer.rb#L38 So, it is good not to hard-code /usr/bin/env in tests. Actually, these tests fail on Android because it provides /bin/env available but not /usr/bin/env. https://rubyci.org/logs/rubyci.s3.amazonaws.com/android28-x86_64/ruby-master/log/20200324T074312Z.fail.html.gz
|
This change had been introduced in ruby/ruby but (maybe accidentally) removed by ruby/ruby#2889 :-) @deivid-rodriguez |
|
Thank you @mame! Yes, it was unintentional. Since the changes had not been contributed upstream, they got unintentionally reverted when syncing when upstream master. |
deivid-rodriguez
approved these changes
Mar 24, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RubyGems chooses available one from the two: /usr/bin/env or /bin/env
rubygems/lib/rubygems/installer.rb
Line 38 in 20b0d60
So, it is good not to hard-code /usr/bin/env in tests.
Actually, these tests fail on Android because it provides /bin/env
available but not /usr/bin/env.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/android28-x86_64/ruby-master/log/20200324T074312Z.fail.html.gz