Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify explicit separator not to be affected by $; #3424

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

nobu
Copy link
Contributor

@nobu nobu commented Mar 24, 2020

Description:

Get rid to be affected by $;.

What was the end-user or developer problem that led to this PR?

Usually nothing.
When using rubygems as a library, the global variable can be set non-nil value.

What is your fix for the problem, implemented in this PR?

Specify separator argument to String#split explicitly.


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This avoids an issue which could be tricky to debug for a user. LGTM!

@deivid-rodriguez
Copy link
Member

Thanks @nobu!!

@deivid-rodriguez deivid-rodriguez merged commit c948d5a into rubygems:master Mar 25, 2020
@nobu nobu deleted the bug/split-separator branch March 24, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants