Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect gem uninstall --all message #3483

Merged
merged 1 commit into from Apr 7, 2020

Conversation

deivid-rodriguez
Copy link
Member

Description:

Currently gem uninstall --all shows the following incorrect message
after completion:

INFO:  Uninstalled all gems in

Now it shows something that actually makes sense like:

INFO:  Uninstalled all gems in /home/deivid/Code/rubygems/tmp/test_rubygems_6986/gemhome

Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

@deivid-rodriguez deivid-rodriguez force-pushed the fix_incorrect_gem_uninstall_message branch 3 times, most recently from d5a7a52 to 354aabe Compare April 6, 2020 18:38
Currently `gem uninstall --all` shows the following incorrect message
after completion:

```
INFO:  Uninstalled all gems in
```

Now it shows something that actually makes sense like:

```
INFO:  Uninstalled all gems in /home/deivid/Code/rubygems/tmp/test_rubygems_6986/gemhome
```
@deivid-rodriguez deivid-rodriguez force-pushed the fix_incorrect_gem_uninstall_message branch from 354aabe to 8fa05e8 Compare April 7, 2020 13:42
@deivid-rodriguez deivid-rodriguez merged commit 041c7e7 into master Apr 7, 2020
@deivid-rodriguez deivid-rodriguez deleted the fix_incorrect_gem_uninstall_message branch April 7, 2020 21:01
@hsbt hsbt added this to the 3.1.3 milestone May 4, 2020
hsbt pushed a commit that referenced this pull request May 4, 2020
…ssage

Fix incorrect `gem uninstall --all` message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants