Fix broken exception recovery code when installing plugins #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Sorry for the long delay getting into this!
Only minor comment would be to make the plugin names more clear in the error message. Maybe
Failed to install the following plugins: <comma_separated_list_with_names_wrapped_in_backquotes>. The underlying error was: <the_error_as_it_is_printed_now>
What do you think?
fatkodima
force-pushed
the
fix-plugin-install-rescue
branch
from
d23c7b7
to
4c82409
Compare
fatkodima
force-pushed
the
fix-plugin-install-rescue
branch
from
4c82409
to
c813260
Compare
|
@deivid-rodriguez Updated with your suggestion. |
|
Thanks so much, I'll merge this tomorrow! |
deivid-rodriguez
approved these changes
Jul 14, 2020
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Fix broken exception recovery code when installing plugins (cherry picked from commit b277c8c)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Fix broken exception recovery code when installing plugins (cherry picked from commit b277c8c)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Fix broken exception recovery code when installing plugins (cherry picked from commit b277c8c)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Fix broken exception recovery code when installing plugins (cherry picked from commit b277c8c)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Fix broken exception recovery code when installing plugins (cherry picked from commit b277c8c)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Fix broken exception recovery code when installing plugins (cherry picked from commit b277c8c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3484