Don't change ruby process CWD when building extensions #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
deivid-rodriguez
force-pushed
the
thread_safe_extension_building
branch
from
4c7092f
to
8047e8b
Compare
deivid-rodriguez
force-pushed
the
thread_safe_extension_building
branch
from
8047e8b
to
c4d84b0
Compare
deivid-rodriguez
force-pushed
the
thread_safe_extension_building
branch
from
c4d84b0
to
c569fde
Compare
|
This looks great! |
deivid-rodriguez
force-pushed
the
thread_safe_extension_building
branch
from
c569fde
to
8f8bcb5
Compare
|
I had forgotten about this. I rebased it! |
deivid-rodriguez
force-pushed
the
thread_safe_extension_building
branch
from
8f8bcb5
to
1b7a5f1
Compare
deivid-rodriguez
force-pushed
the
thread_safe_extension_building
branch
2 times, most recently
from
caa1f1d
to
d6fbc31
Compare
Change it in subprocesses, so it's thread safe.
deivid-rodriguez
force-pushed
the
thread_safe_extension_building
branch
from
d6fbc31
to
e600431
Compare
|
Let's do it! |
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Don't change ruby process CWD when building extensions (cherry picked from commit 8b50ccf)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Don't change ruby process CWD when building extensions (cherry picked from commit 8b50ccf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This leads to simpler code because we don't need to maintain a mutex to ensure thread safety.
Tasks:
I will abide by the code of conduct.