Rollback gem deprecate #3530
Rollback gem deprecate #3530
Conversation
bronzdoc
force-pushed
the
rollback_gem_deprecate
branch
from
1d93e72
to
024267f
Compare
|
I think this is good enough for now. We can take a look at internal deprecation improvements later. |
| repl == :none ? " with no replacement" : "; use #{repl} instead", | ||
| ". It will be removed on or after %4d-%02d-01." % [year, month], | ||
| "\n#{target}#{name} called from #{Gem.location_of_caller.join(":")}", | ||
| ] |
There was a problem hiding this comment.
I believe we are introducing here the same kind of issue we're trying to solve in #3506: we're showing a deprecation message only meant for gem authors to all users. And we're showing this deprecation message about the deprecation system right next to the deprecation of a method that end users do care about.
I feel we might cause brain damage to our users 😆.
So, I believe we should revert the deprecation of Gem::Deprecate for now until we figure out good strategies to be smart about whether we are in an end user context or in a gem development context, and apply them to this particular case.
There was a problem hiding this comment.
I have missed that. I agree on removing this deprecation warning for now.
There was a problem hiding this comment.
FWIW, I placed this comment at the wrong place, my comments refers to the line below this one, just to clarify.
There was a problem hiding this comment.
I'm not sure if there's other way to do this without end users seeing the deprecation warning. 🤔
This is not something that we could check at build time...
There was a problem hiding this comment.
I think we can try to approximate it. A first idea that came to my mind was whether there's a ".gemspec" file at the CWD or up in the directory hierarchy.
There was a problem hiding this comment.
Can we just remove it for now (should I provide PR?) and discuss this as a follow-up in new issue?
There was a problem hiding this comment.
Yes, yes, that's exactly what I was suggesting.
| ## | ||
| # Simple deprecation method that deprecates +name+ by wrapping it up | ||
| # in a dummy method. It warns on each call to the dummy method | ||
| # telling the user of +repl+ (unless +repl+ is :none) and the | ||
| # Rubygems version that it is planned to go away. | ||
|
|
||
| def deprecate(name, replacement=:none) | ||
| def rubygems_deprecate(name, replacement=:none) |
There was a problem hiding this comment.
I think the new name conveys it quite well, but we should make it super clear that this is an internal module, not a public one for everyone to use. Not sure which strategies are tipically used for this.
deivid-rodriguez
added
rubygems: enhancement
and removed
rubygems: minor enhancement
labels
Description:
closes #3512
This PR does a few things:
I will abide by the code of conduct.