Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve missing spec error #3559

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Improve missing spec error #3559

merged 2 commits into from
Apr 26, 2020

Conversation

bronzdoc
Copy link
Member

Closes #3521

Show gemspec location when a Gem::MissingSpecError is raised while trying to activate a gem

I will abide by the code of conduct.

deivid-rodriguez
deivid-rodriguez approved these changes Apr 26, 2020
View reviewed changes
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does fix the OP issue, and improves things overall, so I'm good after a second thought 👍

@bronzdoc bronzdoc merged commit f35c53c into master Apr 26, 2020
@bronzdoc bronzdoc deleted the improve-missing-spec-error branch April 26, 2020 20:27
@Irakaj93 Irakaj93 mentioned this pull request Dec 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simi simi simi approved these changes

@deivid-rodriguez deivid-rodriguez deivid-rodriguez approved these changes

Assignees
No one assigned
Labels
RubyGems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please improve Gem::MissingSpecError error message
4 participants
@bronzdoc @simi @deivid-rodriguez @bundlerbot