Don't load system rubygems at all when RGV specified for tests
#3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
dont_load_system_rubygems_at_all
branch
3 times, most recently
from
54778ec
to
1ca285d
Compare
Since it doesn't seem preserved by default.
This list of exceptions is no longer rescued since 1f03275.
I have no idea why, but when trying to change this spec so that the environment is passded more `RUBYOPT`'s, it starts failing complaining that no inline code was passed to `ruby -e`. I presume it was some escaping issue, so I rewrote it in a simpler way which gives no issues.
This spec is very fragile to changes in `RUBYOPT`. I rewrote it to test just was the spec is trying to verufy, namely, that `-rbundler/setup` is not added twice to `RUBYOPT`.
This code was added in rubygems/bundler@a1202ef just for the sake of passing tests. However, it's not needed these days. And it's also causing system rubygems to be unitentionally loaded on ruby 2.3 for some reason.
deivid-rodriguez
force-pushed
the
dont_load_system_rubygems_at_all
branch
from
1ca285d
to
ab2e43d
Compare
|
Yay! Bundler tested against a specific rubgems version (setting
The test I added involve an |
|
Merging this. Happy to address comments/concerns on followup PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In #3592 I noticed that "system rubygems" is being loaded by our tests. I think this is fine if we don't specify
ENV["RGV"]but if we do, rubygems should always be picked up from there.This PR tries to implement that.
Tasks:
I will abide by the code of conduct.