Log messages to stdout in rake package
#3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
log_messages_to_stdout
branch
from
0667e34
to
2593e05
Compare
4 tasks
bronzdoc
approved these changes
May 18, 2020
bronzdoc
reviewed
May 18, 2020
So that I can add a separate test that doesn't set it.
The logging to $stderr is only happening due to a bug in `FileUtils`. Logging messages are not errors.
deivid-rodriguez
force-pushed
the
log_messages_to_stdout
branch
from
2593e05
to
4d1b665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
During some separate work, I was trying to make sure that
rake installdoesn't print any warnings in CI.So what I was doing is:
To my surprise, the file was full of logging messages from the
rake packagetask.The underlying issue is ruby/fileutils#49.
But I think we can workaround it with this PR.
Tasks:
I will abide by the code of conduct.