Avoid stack overflow inside StubSpecification on some edge cases
#3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix_bundle_exec_bundle_install_git_extension
branch
from
a62b770
to
c98e2f8
Compare
The higher level consequence of defining the method is correct, since each source checks `missing_specs?` of every installed spec when building its index However, the purpose of the specific method is to avoid loading the corresponding full specification of that stub, so let's make a more focused comment.
This method name had a typo, since the method in the full specification is called `default_gem?` not `default_gem`. That typo being unnoticed most likely indicates that the method was not being run at all. However, since I intend to use it in later commits, I'm fixing the typo and not removing it.
By explicitly defining a couple more methods, we can avoid loading the full specification in all cases, including pathological ones that currently lead to stackoverflow errors.
deivid-rodriguez
force-pushed
the
fix_bundle_exec_bundle_install_git_extension
branch
from
d767edc
to
226ec11
Compare
|
I ended up changing the strategy from the original PR to make sure that we don't load the full specification even in the edge case of the referenced issue. Also added some other improvements while investigating the issue. I believe it's ready. |
deivid-rodriguez
changed the title
to_spec whenever it is referencedStubSpecification on some edge cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a port of rubygems/bundler#6653 from the old repo, which closes #3365.
Tasks:
I will abide by the code of conduct.