Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden bundler template installation from rubygems updater #3674

Merged

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

When gem update --system installs bundler as a default gem, it was not installing any templates inside hidden folders.

I found this issue while reviewing #3667.

What is your fix for the problem, implemented in this PR?

The fix is to use Dir.glob with the File::FNM_DOTMATCH flag so that these files are not ignored.

Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

@deivid-rodriguez deivid-rodriguez merged commit ec04966 into master Jun 4, 2020
@deivid-rodriguez deivid-rodriguez deleted the fix_bundler_default_gems_template_installation branch June 4, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants