Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI at 3.1 branch head as well. #3677

Merged
merged 2 commits into from Jun 3, 2020
Merged

Run CI at 3.1 branch head as well. #3677

merged 2 commits into from Jun 3, 2020

Conversation

simi
Copy link
Member

@simi simi commented Jun 2, 2020

Hello, I was about to check 3.1 head branch CI status after recent merges and I have spotted it doesn't start build on push. This change should change it.

@bundlerbot bundlerbot added the CI CI related issues label Jun 2, 2020
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@deivid-rodriguez
Copy link
Member

Looks like the https change needed some updates.

@simi
Copy link
Member Author

simi commented Jun 2, 2020

@deivid-rodriguez yes, this fail was expected. Both branches merged were green on its own, but red merged together. That was the reason for being curious about the homu ability to update pull requests after merge in automated way.

@deivid-rodriguez
Copy link
Member

Yes, this is something bors-ng would've detected indeed. Not sure if they will have fixed the issues that made us removing it, but I'm happy with not using it, honestly.

@hsbt
Copy link
Member

hsbt commented Jun 3, 2020

Thanks!

@hsbt hsbt merged commit 602d93d into rubygems:3.1 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants