Make sure tmp folder exists before calling Dir.tmpdir
#3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simi
approved these changes
Jun 11, 2020
|
I tried this against ruby-core and it didn't work at all, so I'll set this as WIP. |
deivid-rodriguez
force-pushed
the
saner_tmp_handling
branch
from
c9ee2d3
to
15a64e5
Compare
This was guaranteed by our gitignore setup where a `tmp/` folder is always present right after cloning the repository, but was not guaranteed under the ruby-core setup. This alternative approach should always work.
deivid-rodriguez
force-pushed
the
saner_tmp_handling
branch
from
15a64e5
to
108821f
Compare
|
Merging this because I managed to get ruby-core tests working with #3132 on top of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This was guaranteed by our gitignore setup where a
tmp/folder is always present right after cloning the repository, but was not guaranteed under the ruby-core setup.This alternative approach should always work.
Tasks:
I will abide by the code of conduct.