Tweaks to play nice with ruby-core setup #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
changed the title
Namely, those generated under `./tmp`. The previous approach was brittle and broken in the case of ruby-core, because under that setup, the root folder is in the original `$LOAD_PATH`, and dummy features are created under `./tmp`, and due to the check that I'm removing in this commit, they were failing to be reset.
Ruby-core runs rubygems tests in parallel, and the previous setup doesn't play nice with that.
deivid-rodriguez
force-pushed
the
tmp_dir_tweaks
branch
from
3304e9e
to
28ae49a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a couple of tweaks to our test setup to play nice to the environment where our test run inside the ruby repository. With these commits, #3725 should go green.
Already tested at ruby/ruby#3213.
Tasks:
I will abide by the code of conduct.