Allow setting a tag prefix to be used by gem release tasks #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
What was the end-user or developer problem that led to this PR?
In order to be able to release rubygems & bundler from the same repo, we need to make sure that the generated tags don't overwrite each other. For example, we don't want the tag for the bundler 2.2.0 release to overwrite the tag for the rubygems 2.2.0 release.
What is your fix for the problem, implemented in this PR?
My fix is to provide a
Bundler::GemHelper.tag_prefix=setter to be able to have some control over the tag names. I plan to use it like here.Honestly, I don't specially like this solution, but it fixes the issue and unblocks the releases. I'm happy to hear other proposals though.
Tasks:
I will abide by the code of conduct.