Fix rake release aborting when credentials file is missing, even if properly configured through XDG
#3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gem push` already asks for credentials on the fly and properly save them for future runs if they are not already there, so I believe this is unnecessary.
colby-swandale
approved these changes
Jul 6, 2020
hsbt
approved these changes
Jul 7, 2020
deivid-rodriguez
changed the title
rake release aborting when credentials file is missing, even if properly configured through XDG
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 5, 2020
…als_file Don't abort release on missing credentials file (cherry picked from commit 2fa3bc6)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 5, 2020
…als_file Don't abort release on missing credentials file (cherry picked from commit 2fa3bc6)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 5, 2020
…als_file Don't abort release on missing credentials file (cherry picked from commit 2fa3bc6)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 6, 2020
…als_file Don't abort release on missing credentials file (cherry picked from commit 2fa3bc6)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 6, 2020
…als_file Don't abort release on missing credentials file (cherry picked from commit 2fa3bc6)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 6, 2020
…als_file Don't abort release on missing credentials file (cherry picked from commit 2fa3bc6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
gem pushalready asks for credentials on the fly and properly savethem for future runs if they are not already there, so I believe this is
unnecessary.
This is an initial proposal to fix #3779.
Tasks:
I will abide by the code of conduct.