Don't format executables on gem update --system
#3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores 3.0 behavior and goes back to not formatting executables by default on `gem update --system`. This is friendlier for jruby and doesn't really affect OS packagers.
deivid-rodriguez
force-pushed
the
gem_update_system_no_format_executables
branch
from
e4fd24e
to
1a504b6
Compare
|
Merging this because it was consensuated with OS packagers and jruby. |
4 tasks
hsbt
pushed a commit
that referenced
this pull request
Sep 23, 2020
…ecutables Don't format executables on `gem update --system`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This restores 3.0 behaviour and goes back to not formatting executables by default on
gem update --system. This is friendlier for jruby and doesn't really affect OS packagers. And having changed this is actually a regression because it was never intended.This is actually already tested by our
install-rubygems.ymlworkflow, but we currently include a workaround in our "developmentgem update --systemsimulator task" to avoid the issue on jruby. This PR also removes the workaround.Fixes #3564.
Tasks:
I will abide by the code of conduct.