Warn on duplicate dependency in a specification #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm ok for this to be merged, but I'm curious, are there any examples where people are doing this? |
|
I detected cases like this when inspecting server data while reviewing some recent data fixes on the rubygems.org side, like rubygems/rubygems.org#2343 and related PRs. I figured it was probably due to typos and I thought it'd be nice to detect them when gems are built. |
hsbt
pushed a commit
that referenced
this pull request
Sep 23, 2020
…ification Warn on duplicate dependency in a specification
deivid-rodriguez
added
rubygems: enhancement
and removed
rubygems: minor enhancement
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes #3676
Warns whenever we have a duplicate runtime dependency
spec.add_runtime_dependency "rails", "~> 3.0", "~> 3.0"#=>WARNING: duplicated rails dependency ["~> 3.0", "~> 3.0"]I will abide by the code of conduct.