Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update man page and deprecation warning for binstubs --all #3872

Merged

Conversation

rreinhardt9
Copy link
Contributor

Resolves #3251

Update the deprecation warning to point the user to the --all option
for bundle binstubs as the preferred way to install binstubs for all
gems in a bundle.

Update bundle binstubs man page to include the --all option 馃帀
and remove the note pointing to the now deprecated method of installing
all binstubs.

@welcome
Copy link

welcome bot commented Aug 2, 2020

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

@rreinhardt9
Copy link
Contributor Author

I'm super new to contributing period and to rubygems specifically, so do let me know if there is something I can do to be more helpful because I probably just don't realize it 馃槅

One question that popped up when working on this; when running bin/rake man:build it creates a bunch of diffs in other places besides just the man page I changed. I get diffs on these output files:
Screen Shot 2020-08-02 at 2 35 51 PM

But the weird part is that it's just adding/removing whitespace to balance out the words in the row 馃
Screen Shot 2020-08-02 at 2 36 01 PM

I didn't commit those updates because it seemed like that was probably something with my configuration because otherwise the CI check would have not passed for other branches I would figure. Is that a correct assumption or is should I look more into that?

Resolves rubygems#3251

Update the deprecation warning to point the user to the `--all` option
for bundle binstubs as the preferred way to install binstubs for all
gems in a bundle.

Update `bundle binstubs` man page to include the `--all` option 馃帀
and remove the note pointing to the now deprecated method of installing
all binstubs.
@rreinhardt9 rreinhardt9 marked this pull request as ready for review August 2, 2020 20:36
@deivid-rodriguez
Copy link
Member

Thanks so much @rreinhardt9!!

@deivid-rodriguez deivid-rodriguez merged commit 228e033 into rubygems:master Aug 29, 2020
@rreinhardt9 rreinhardt9 deleted the binstubs-manpage-update branch August 29, 2020 16:21
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Update man page and deprecation warning for binstubs --all

(cherry picked from commit 228e033)
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Update man page and deprecation warning for binstubs --all

(cherry picked from commit 228e033)
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Update man page and deprecation warning for binstubs --all

(cherry picked from commit 228e033)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Update man page and deprecation warning for binstubs --all

(cherry picked from commit 228e033)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Update man page and deprecation warning for binstubs --all

(cherry picked from commit 228e033)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Update man page and deprecation warning for binstubs --all

(cherry picked from commit 228e033)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using binstubs for all gems with the deprecated --binstubs
4 participants